misc: group key testing #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Looks like I caused an issue in unrelated --- FAIL: TestAssetExportLog (0.71s)
test_sqlite.go:11: Creating new SQLite DB for testing
assets_store_test.go:1455:
Error Trace: /home/runner/work/taproot-assets/taproot-assets/tapdb/assets_store_test.go:1455
Error: Not equal:
expected: 0x1
actual : 0x0
Test: TestAssetExportLog
FAIL
FAIL github.com/lightninglabs/taproot-assets/tapdb 9.782s
FAIL |
In this commit, we update multiple unit tests to not set an asset group key directly, and instead use some test helper that calls asset.New(). This ensures that the group witness is copied into the asset. The only time setting the group key directly is acceptable is before a group witness has been created, or in a minting request.
jharveyb
force-pushed
the
group_key_testing
branch
from
94693c6 to
8f77090
Compare
|
Fixed unit flake, asset version wasn't being passed properly. Not sure why |
Roasbeef
approved these changes
Dec 9, 2023
| Witness: a.GroupKey.Witness, | ||
| RawKey: a.GroupKey.RawKey, | ||
| GroupPubKey: a.GroupKey.GroupPubKey, | ||
| TapscriptRoot: a.GroupKey.TapscriptRoot, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spun out of #549 . Adds a few test cases related to group key handling following the group key derivation algorithm changes and storage changes that were included in 0.3.0. We also remove some clearly-redunant error checking in proof validation.
Coverage for
assetincreases by 3.6% to 70.8%, fortapdban increase of 0.2% to 66.1%, and forproofan increase of 0.4% to 56.1%.